Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Add inmem option for nats-js stores #7979

Merged
merged 3 commits into from
Dec 15, 2023
Merged

[full-ci] Add inmem option for nats-js stores #7979

merged 3 commits into from
Dec 15, 2023

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Dec 14, 2023

Adds an option to disable persistence of nats-js and nats-js-kv stores

Fixes #7119

mmattel
mmattel reviewed Dec 14, 2023
View reviewed changes
services/gateway/README.md Outdated Show resolved Hide resolved
@kobergj kobergj requested a review from mmattel December 15, 2023 09:17
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kobergj kobergj force-pushed the InmemNatsjsStore branch 2 times, most recently from 934e9f8 to 7c60dcd Compare December 15, 2023 11:37
@kobergj kobergj marked this pull request as ready for review December 15, 2023 11:37
2403905
2403905 approved these changes Dec 15, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@kobergj
bump reva
db2c311 
Signed-off-by: jkoberg <[email protected]>
mmattel
mmattel approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a docs pov 👍

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kobergj kobergj merged commit b0cfb3d into owncloud:master Dec 15, 2023
3 checks passed
@kobergj kobergj deleted the InmemNatsjsStore branch December 15, 2023 13:28
ownclouders pushed a commit that referenced this pull request Dec 15, 2023
@kobergj
Merge pull request #7979 from kobergj/InmemNatsjsStore
3594fcc 
[full-ci] Add inmem option for nats-js stores
@mmattel mmattel mentioned this pull request Dec 15, 2023
Closed
@micbar micbar mentioned this pull request Dec 20, 2023
Closed
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmattel mmattel mmattel approved these changes

@micbar micbar micbar approved these changes

@2403905 2403905 2403905 approved these changes

@kulmann kulmann Awaiting requested review from kulmann kulmann is a code owner

@lookacat lookacat Awaiting requested review from lookacat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NATS cache support memory storage / replicas
4 participants
@kobergj @mmattel @micbar @2403905