-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Service Account Roles #8051
Conversation
Signed-off-by: jkoberg <[email protected]>
1b2c61d
to
20f77d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions around the env var changes. LGTM otherwise.
@@ -46,6 +46,7 @@ func NewService(cfg *config.Config, logger log.Logger) settings.ServiceHandler { | |||
case "metadata": | |||
service.manager = metastore.New(cfg) | |||
case "filesystem": | |||
fmt.Println("WARNING: filesystem store is deprecated and will be removed in the future. Please use metadata store instead.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Signed-off-by: jkoberg <[email protected]>
e397b58
to
a607c63
Compare
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
[full-ci] Service Account Roles
Adds a hidden role for service accounts. This role will give the service account all permissions it needs but will not appear in list roles calls. Also it doesn't need the default role assignments to work.
Fixes: https://github.com/owncloud/enterprise/issues/6286
Also deprecates
filesystem
settings storeNOTE: This is a breaking change. It removes the (unreleased)
SETTINGS_SERVICE_ACCOUNT_ID_ADMIN
environment variable without deprecation