[test-only] Change naming in sharingNG api-tests #8140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
ScharfViktor
changed the title
ScharfViktor
requested review from
individual-it,
SwikritiT,
SagarGi,
saw-jan,
grgprarup and
nabim777
ScharfViktor
force-pushed
the
changeNaming
branch
from
412614c
to
407fbfd
Compare
saw-jan
approved these changes
Jan 8, 2024
ScharfViktor
force-pushed
the
changeNaming
branch
from
407fbfd
to
6cf8ac5
Compare
ScharfViktor
force-pushed
the
changeNaming
branch
from
6cf8ac5
to
3249152
Compare
|
ownclouders
pushed a commit
that referenced
this pull request
Jan 8, 2024
ownclouders
pushed a commit
that referenced
this pull request
Jan 9, 2024
2403905
pushed a commit
to 2403905/ocis
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after discution #8130 (comment)
In our tests, I found some confusion about the names.
I suggest to define and solve it at an early stage.
example:
so I suggest to use:
When user "Alice" updates the following password for the last link share using the Graph API:toWhen user "Alice" sets the following password for the last link share using the Graph API:not to be confused PATCH request with POST setPassword request