Fix patching language settings #8182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <[email protected]>
rhafer
previously requested changes
Jan 11, 2024
| u.PreferredLanguage = preferredLanguage | ||
| g.patchUserResponse(w, r, u, nameOrID, features) |
There was a problem hiding this comment.
This is not a new issue but I guess the events should always contain the userid (never the name) and nameOrID can indeed be a username. We should probably use u.GetID() for the event. I guess you can just leave out the nameOrID parameter. And have fill the id from the user object in patchUserResponse.
Looks good to me otherwise.
There was a problem hiding this comment.
Good point 👍 Did as requested.
Signed-off-by: jkoberg <[email protected]>
kobergj
force-pushed
the
FixPatchingLanguage
branch
from
fcde47f
to
16106b0
Compare
|
aduffeck
approved these changes
Jan 12, 2024
ownclouders
pushed a commit
that referenced
this pull request
Jan 12, 2024
Fix patching language settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes patching of user language when ldap backend is
read-onlyFixes https://github.com/owncloud/enterprise/issues/6235