Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Fix nats authentication & Improvements #8236

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Jan 17, 2024

  • Fixes authentication for nats
  • Fixes store TTL
  • Removes statcache
  • Sets natsjskv registry to inmemory instead file persistence

@kobergj
Copy link
Collaborator Author

kobergj commented Jan 19, 2024

@dragonchaser I needed to introduce some extra envvars to make authentication work. I followed the old guidelines for envvars

Q1: Should I follow a new scheme already? E.g. not introducing ennvars like GATEWAY_PROVIDER_CACHE_AUTH_PASSWORD but only using the global ones instead?

Q2: Where can I find this list of new envvars in 5.0 release you made? I'll need to add the ones from this PR.

@kobergj kobergj changed the title Fix nats authentication [full-ci] Fix nats authentication Jan 19, 2024
@dragonchaser
Copy link
Member

@dragonchaser I needed to introduce some extra envvars to make authentication work. I followed the old guidelines for envvars

Q1: Should I follow a new scheme already? E.g. not introducing ennvars like GATEWAY_PROVIDER_CACHE_AUTH_PASSWORD but only using the global ones instead?

makes sense imho

Q2: Where can I find this list of new envvars in 5.0 release you made? I'll need to add the ones from this PR.

will send it to you on rc

@micbar micbar added this to the Release 5.0.0 milestone Jan 22, 2024
@kobergj kobergj marked this pull request as ready for review January 23, 2024 10:01
@kobergj kobergj changed the title [full-ci] Fix nats authentication [full-ci] Fix nats authentication & Improvements Jan 23, 2024
Copy link
Contributor

@2403905 2403905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@kobergj
Copy link
Collaborator Author

kobergj commented Jan 24, 2024

Only rebased to master. No further code changes

Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kobergj kobergj merged commit acf0cca into owncloud:master Jan 24, 2024
3 checks passed
ownclouders pushed a commit that referenced this pull request Jan 24, 2024
[full-ci] Fix nats authentication & Improvements
@kobergj kobergj deleted the FixNatsAuthentication branch January 24, 2024 12:47
@kobergj kobergj mentioned this pull request Jan 25, 2024
1 task
@micbar micbar mentioned this pull request Jan 26, 2024
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants