Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the resource name #8246

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix the resource name #8246

merged 1 commit into from
Jan 25, 2024

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Jan 18, 2024

Description

After the sharer changed the name of a shared resource, the receiver can see the new name, but cannot access it by using the new name.
We fixed a problem where after renaming the resource as sharer the receiver saw a new name.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  1. create a folder
  2. share the folder
  3. as sharer rename the folder
  4. as receiver do a propfind on the share-jail curl -XPROPFIND -uuu1:uu1 'https://localhost:9200/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668' -k | xmllint --format -

Expected behavior

d:href element and oc:name should correlate

Actual behavior

d:href, d:displayname and oc:name shows the old name for receiver

response (shortened)

 <d:response>
    <d:href>/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668/folder/</d:href>
    <d:propstat>
      <d:prop>
        <oc:name>folder</oc:name>
        <d:displayname>folder</d:displayname>
      </d:prop>
      <d:status>HTTP/1.1 200 OK</d:status>
    </d:propstat>
  </d:response>

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@2403905 2403905 marked this pull request as ready for review January 18, 2024 14:08
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but needs a reva bump

go.mod Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@2403905 2403905 merged commit 7568cfe into owncloud:master Jan 25, 2024
2 checks passed
ownclouders pushed a commit that referenced this pull request Jan 25, 2024
@micbar micbar mentioned this pull request Jan 26, 2024
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

after renaming resource as sharer the receiver cannot access it by WebDAV using the new name
4 participants