Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: signed url expiry check and signature validation #8385

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

DeepDiver1975
Copy link
Member

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

update-docs bot commented Feb 7, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975 DeepDiver1975 force-pushed the fix/signed-url-expiry-check-and-signature-master branch from 4caf758 to 09e7b76 Compare February 7, 2024 09:43
fix: signed url expiry validation only checks for expiry and not for used before
@DeepDiver1975 DeepDiver1975 force-pushed the fix/signed-url-expiry-check-and-signature-master branch from 09e7b76 to 75cd53d Compare February 7, 2024 12:08
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

6 New issues
0 Security Hotspots
92.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@butonic butonic merged commit b12cff1 into master Feb 7, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/signed-url-expiry-check-and-signature-master branch February 7, 2024 14:44
ownclouders pushed a commit that referenced this pull request Feb 7, 2024
fix: signed url expiry validation only checks for expiry and not for used before
@micbar micbar mentioned this pull request Feb 7, 2024
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants