Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] chore: bump dependencies and go to 1.22 #8586

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Mar 6, 2024

needs owncloud-ci/golang#137 before it can get green

fixes: #8584

@fschade
Copy link
Contributor Author

fschade commented Mar 6, 2024

+ make govulncheck
(re)installing /go/bin/govulncheck-v1.0.1
go: downloading golang.org/x/vuln v1.0.1
go: downloading golang.org/x/tools v0.12.1-0.20230815132531-74c255bcf846
go: downloading golang.org/x/sync v0.3.0
go: downloading golang.org/x/sys v0.11.0
/go/bin/govulncheck-v1.0.1 ./...
Scanning your code and 1695 packages across 318 dependent modules for known vulnerabilities...

No vulnerabilities found.

Share feedback at https://go.dev/s/govulncheck-feedback.

@phil-davis
Copy link
Contributor

go-vulnerability-scan has passed - good.
https://drone.owncloud.com/owncloud/ocis/32673/9/6

@fschade fschade changed the title chore: bump dependencies and go to 1.22 [full-ci] chore: bump dependencies and go to 1.22 Mar 6, 2024
@micbar
Copy link
Contributor

micbar commented Mar 6, 2024

please backport to stable-5.0 and stable-4.0

@phil-davis phil-davis marked this pull request as ready for review March 6, 2024 08:46
@phil-davis
Copy link
Contributor

phil-davis commented Mar 6, 2024

https://drone.owncloud.com/owncloud/ocis/32673/7/6

golangci-lint step failed.

evel=error msg="Running error: 1 error occurred:\n\t* 
can't run linter goanalysis_metalinter: goanalysis_metalinter: SA1027: package \"sync\" (isInitialPkg: true, needAnalyzeSource: true): 
runtime error: invalid memory address or nil pointer dereference\n\n"

@fschade
Copy link
Contributor Author

fschade commented Mar 6, 2024

https://drone.owncloud.com/owncloud/ocis/32673/7/6

golangci-lint step failed.

evel=error msg="Running error: 1 error occurred:\n\t* 
can't run linter goanalysis_metalinter: goanalysis_metalinter: SA1027: package \"sync\" (isInitialPkg: true, needAnalyzeSource: true): 
runtime error: invalid memory address or nil pointer dereference\n\n"

i ❤️ the phil live ticker, keep on... 🤗 , fixed.

@fschade fschade force-pushed the bump-deps-03-06-24 branch 2 times, most recently from 12da406 to 88a1e0b Compare March 6, 2024 10:12
@phil-davis
Copy link
Contributor

https://sonarcloud.io/project/issues?resolved=false&sinceLeakPeriod=true&pullRequest=8586&id=owncloud_ocis
For example: replacement are not allowed: github.com/go-micro/plugins/v4/store/nats-js-kv

drone passes, so do we merge this?

@fschade
Copy link
Contributor Author

fschade commented Mar 6, 2024

https://sonarcloud.io/project/issues?resolved=false&sinceLeakPeriod=true&pullRequest=8586&id=owncloud_ocis For example: replacement are not allowed: github.com/go-micro/plugins/v4/store/nats-js-kv

drone passes, so do we merge this?

nope, please wait... i want to have the replaces explicit whitelisted

Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@phil-davis phil-davis merged commit 58e28a0 into owncloud:master Mar 6, 2024
3 checks passed
ownclouders pushed a commit that referenced this pull request Mar 6, 2024
[full-ci] chore: bump dependencies and go to 1.22
@micbar micbar mentioned this pull request Mar 13, 2024
71 tasks
@micbar micbar mentioned this pull request Jun 19, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go-vulnerability-scan is failing CI
4 participants