Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Multiparts uploads #8666

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Mar 15, 2024

Multipart uploads do cause extreme memory consumption

@mmattel
Copy link
Contributor

mmattel commented Mar 15, 2024

Is there an envvar behind the change and if yes, should this/the behaviour be mentioned in the docs?

Copy link

sonarcloud bot commented Mar 15, 2024

@kobergj
Copy link
Collaborator Author

kobergj commented Mar 15, 2024

@mmattel We need to find out how to mitigate the issue before we update docs or env descriptions.

@micbar micbar merged commit f6af0fa into owncloud:master Mar 15, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Mar 15, 2024
@butonic
Copy link
Member

butonic commented Mar 15, 2024

AFAICT we should disable s3.concurrent_stream_parts by setting it to false and not
s3.disable_multipart. defaulting it to true will cement bool defaults to true which is something admins should explicitly enable.

IMO defaulting s3.concurrent_stream_parts to true was wrong by me.

@kobergj kobergj deleted the DisableMultipartUploads branch March 18, 2024 08:08
@micbar micbar mentioned this pull request Jun 19, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants