Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal links shouldn't have a password #8668

Merged
merged 2 commits into from
Mar 18, 2024
Merged

internal links shouldn't have a password #8668

merged 2 commits into from
Mar 18, 2024

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Mar 15, 2024 •
edited
Loading

Description

Internal links shouldn't have a password

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@2403905 2403905 requested a review from rhafer March 15, 2024 16:52
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@2403905
Copy link
Contributor Author

2403905 commented Mar 18, 2024

@ScharfViktor Please update the test cases.

@ScharfViktor ScharfViktor merged commit 246f7bf into owncloud:master Mar 18, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Mar 18, 2024
@2403905
internal links shouldn't have a password (#8668)
babbc7c 
* internal links shouldn't have a password

* commented out incorrect cases
@ScharfViktor ScharfViktor mentioned this pull request Mar 18, 2024
Merged
3 tasks
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor left review comments

@kobergj kobergj kobergj approved these changes

@rhafer rhafer Awaiting requested review from rhafer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Sharing NG] Internal links shouldn't have a password
3 participants
@2403905 @kobergj @ScharfViktor