Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Remove Resharing #8762

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Apr 2, 2024

Removes resharing from codebase

Backend part of #8842

@kobergj kobergj force-pushed the RemoveResharing branch 8 times, most recently from 1cc73e2 to 9c5def3 Compare April 4, 2024 08:56
@kobergj kobergj marked this pull request as ready for review April 4, 2024 08:56
Signed-off-by: jkoberg <[email protected]>
Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Bugs (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Signed-off-by: jkoberg <[email protected]>
@butonic
Copy link
Member

butonic commented Apr 5, 2024

When I created a view only user share for file in a project space it becomes a share with custom permissions with this PR. IS that intended? Why does it not detect the view permission? Are the heuristics broken?

@butonic
Copy link
Member

butonic commented Apr 5, 2024

Seems to have been a hiccup. I cannot reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants