fix(public-share-auth): allow to create new documents in public share folder

[rhafer]

The public share authentication middleware only allowed to open existing documents the /app/new route was missing.

Fixes #8691

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[dragonchaser]

Fixes it for regular shares. In spaces it removes the 401 (so files can be created), but still ends up with a 500 when the file is being opened (independently from whether it has just been created or opening an existing odt file).

ocis-1                         | {"level":"error","service":"gateway","pkg":"rgrpc","traceid":"426d3963ed3f561af296b82d612035a2","user-agent":"Mozilla/5.0 (X11; Linux x86_64; rv:124.0) Gecko/20100101 Firefox/124.0","from":"tcp://172.20.0.3:36272","uri":"/cs3.gateway.v1beta1.GatewayAPI/OpenInApp","start":"11/Apr/2024:09:20:49 +0000","end":"11/Apr/2024:09:20:49 +0000","time_ns":24474198,"code":"PermissionDenied","time":"2024-04-11T09:20:49Z","line":"github.com/cs3org/reva/[email protected]/internal/grpc/interceptors/log/log.go:69","message":"gateway: error calling OpenInApp: rpc error: code = PermissionDenied desc = auth: core access token is invalid"}
ocis-1                         | {"level":"error","service":"frontend","pkg":"rhttp","traceid":"7f10ea494e9ecc5ba2fa608839997e4b","request-id":"0c1f2555-f55c-48fd-99ec-445fc68463cd","error":"rpc error: code = PermissionDenied desc = gateway: error calling OpenInApp: rpc error: code = PermissionDenied desc = auth: core access token is invalid","time":"2024-04-11T09:20:49Z","line":"github.com/cs3org/reva/[email protected]/internal/http/services/appprovider/errors.go:63","message":"Error contacting the requested application, please use a different one or try again later"}
ocis-1                         | {"level":"error","service":"frontend","pkg":"rhttp","traceid":"7f10ea494e9ecc5ba2fa608839997e4b","host":"127.0.0.1","method":"POST","uri":"/app/open?file_id=9f49bd98-b3d2-4331-8950-764d1b358832%248021048c-7d23-4e34-85a8-e223038d40f3%21697c57ff-8a46-40cd-a96e-577681244bef&lang=en&app_name=Collabora&view_mode=write","url":"/open?file_id=9f49bd98-b3d2-4331-8950-764d1b358832%248021048c-7d23-4e34-85a8-e223038d40f3%21697c57ff-8a46-40cd-a96e-577681244bef&lang=en&app_name=Collabora&view_mode=write","proto":"HTTP/1.1","status":500,"size":134,"start":"11/Apr/2024:09:20:49 +0000","end":"11/Apr/2024:09:20:49 +0000","time_ns":30670724,"time":"2024-04-11T09:20:49Z","line":"github.com/cs3org/reva/[email protected]/internal/http/interceptors/log/log.go:112","message":"http"}

[rhafer]

@dragonchaser Hm, I can't reproduce that. I can open and create new office documents anywhere. (Works with space, public links and user shares)

[rhafer]

@dragonchaser nevermind. I think I found a way to reproduce the 500 error. It only happens if you share the space root via a link. I only try sharing folder within a space.

But I really think that is yet another bug. Should probably address with a separate PR.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud