Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] adding test for listing permission of shares drive #8904

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Apr 19, 2024

Description

this pr adds test for listing permissions of shares drive

added scenarios

Scenario: user lists the permissions of Shares drive using permissions endpoint

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • locally
  • ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Comment on lines 1085 to 1871
When user "Alice" lists the permissions of space "Shares" using the Graph API
Then the HTTP status code should be "200"
And the JSON data of the response should match
"""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScharfViktor we have two APIs for listing permission for drives i.e.:

  1. https://owncloud.dev/libre-graph-api/#/drives.root/ListPermissionsSpaceRoot
  2. https://owncloud.dev/libre-graph-api/#/drives.permissions/ListPermissions

imo those API should should give same output but. when listing permission of shares space
we get different response

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need clarification/confirmation

CC @rhafer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made an issue regarding this #8922

Comment on lines 1085 to 1871
When user "Alice" lists the permissions of space "Shares" using the Graph API
Then the HTTP status code should be "200"
And the JSON data of the response should match
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need clarification/confirmation

CC @rhafer

@nirajacharya2
Copy link
Contributor Author

nirajacharya2 commented Apr 24, 2024

currently blocked by #8922

Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I thought it was a duplicate https://github.com/owncloud/ocis/pull/9438/files#diff-77314df4d252124f66502910bdfc4343a87d01f39299398d45182c1d1ca5caedR1363-R1384

then I saw that it's different endpoint. Maybe it makes scence to split feature file?

@saw-jan
Copy link
Member

saw-jan commented Jun 25, 2024

then I saw that it's different endpoint. Maybe it makes scence to split feature file?

yeah, we have to organize the scenarios to differentiate between root and permissions endpoints. but in next PR

Copy link

sonarcloud bot commented Jun 28, 2024

@ScharfViktor ScharfViktor merged commit 4196b66 into master Jun 28, 2024
3 checks passed
ownclouders pushed a commit that referenced this pull request Jun 28, 2024
 [tests-only][full-ci] adding test for listing permission of shares drive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants