always initialize http handler #8946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
commented
Apr 24, 2024
| Logger: logger, | ||
| Config: *cfg, | ||
| OidcClient: oidcClient, | ||
| OidcHttpClient: oidcHTTPClient, |
There was a problem hiding this comment.
this line is the actual fix, the rest is bonus
|
kobergj
approved these changes
Apr 24, 2024
ownclouders
pushed a commit
that referenced
this pull request
Apr 25, 2024
always initialize http handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8703
I also moved the oidcUrl from a struct property to a parameter of the handler func as it is only used there. By moving the parsing of the url right next to the handler we improve the Locality of Behavior.