Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version command to ocis #915

Merged
merged 1 commit into from
Nov 20, 2020
Merged

add version command to ocis #915

merged 1 commit into from
Nov 20, 2020

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Nov 20, 2020

The version command was only implemented in the extensions.
This adds the version command to ocis to list all services in the ocis namespace.

@C0rby C0rby self-assigned this Nov 20, 2020
@kulmann
Copy link
Member

kulmann commented Nov 20, 2020

This shows output like this - is that the intended result? because it shows 0.0.0 for every service.

+---------+----------------------+------------------------------------------------------------------+
| Version |       Address        |                                Id                                |
+---------+----------------------+------------------------------------------------------------------+
| 0.0.0   | 192.168.178.80:9180  | com.owncloud.api.accounts-8085852e-320c-4909-88f0-cb822831590f   |
| 0.0.0   | 192.168.178.80:57968 | com.owncloud.api.store-0785286f-73fc-4ee0-9b01-96ec6f57d6a0      |
| 0.0.0   | 192.168.178.80:9185  | com.owncloud.api.thumbnails-52006766-0191-4f36-b71a-05ca4b2ab553 |
| 0.0.0   | 192.168.178.80:9181  | 298a4f89-e627-43e4-bceb-3bc26e2b6d15                             |
| 0.0.0   | 192.168.178.80:9110  | ae5123aa-e7de-4834-9dae-5d51ba6010a7                             |
| 0.0.0   | 192.168.178.80:9130  | d6f28fe1-762d-4f50-8a8d-40f37d448e11                             |
| 0.0.0   | 192.168.178.80:9190  | c31d397f-48fe-4163-a689-396026f25c24                             |
|         | 0.0.0.0:9142         | com.owncloud.storage-eff60f89-b799-4239-ab17-617efcbd36b3        |
| 0.0.0   | 192.168.178.80:9115  | fa824047-5d06-4fe6-a9a0-83f95bbbb710                             |
| 0.0.0   | 192.168.178.80:9200  | 59b296d0-52eb-44a4-ae14-504a31ba4a59                             |
| 0.0.0   | 192.168.178.80:9191  | com.owncloud.api.settings-7fde526e-1503-4778-93dd-98052dd42732   |
| latest  | 192.168.178.80:57965 | com.owncloud.api-cbb9cd1c-1cd2-4360-a601-ac55d1040dbc            |
| 0.0.0   | 192.168.178.80:9100  | d66a5fc3-1ab0-4354-a399-c652bb853d19                             |
| latest  | 192.168.178.80:8000  | com.owncloud.registry-7914487e-cce1-4353-89af-eaad28be7c23       |
| latest  | 192.168.178.80:57964 | com.owncloud.web-838fe8b4-7619-4c82-9f11-5431566f15a7            |
+---------+----------------------+------------------------------------------------------------------+

@C0rby
Copy link
Contributor Author

C0rby commented Nov 20, 2020

How was the binary compiled?
0.0.0 means that there was no version provided during compilation

@kulmann
Copy link
Member

kulmann commented Nov 20, 2020

Aha, that output was created with go run cmd/ocis/main.go version ;-)

So with make build and ./bin/ocis version I get this:

+----------+----------------------+------------------------------------------------------------------+
| Version  |       Address        |                                Id                                |
+----------+----------------------+------------------------------------------------------------------+
| 79f45cb7 | 192.168.178.80:9180  | com.owncloud.api.accounts-ae9884fd-62ff-44ba-88ac-514cc9995423   |
| 79f45cb7 | 192.168.178.80:9130  | 2c15cd20-f7be-477c-a2a6-a0147002b45a                             |
| 79f45cb7 | 192.168.178.80:9185  | com.owncloud.api.thumbnails-c480ba1f-df0f-4ab2-8631-dd6e1a46a06e |
| 79f45cb7 | 192.168.178.80:9181  | ede475f3-4f67-41f4-a932-631eaeab8599                             |
| 79f45cb7 | 192.168.178.80:9115  | e1e40bab-b1f6-45da-ad1a-4f91dfa5007a                             |
|          | 0.0.0.0:9142         | com.owncloud.storage-00625efc-398c-48e2-b047-bf3d4747d950        |
| 79f45cb7 | 192.168.178.80:9191  | com.owncloud.api.settings-636e4316-2e90-4dcc-bbae-468546aab2b4   |
| 79f45cb7 | 192.168.178.80:60147 | com.owncloud.api.store-12b3226a-70d0-443f-a039-177c61a220ee      |
| 79f45cb7 | 192.168.178.80:9200  | 5eff38fb-4fef-4d33-8112-6cc0d6be9cb5                             |
| latest   | 192.168.178.80:8000  | com.owncloud.registry-02569087-19dc-4201-a6c3-66cc1e35b328       |
| 79f45cb7 | 192.168.178.80:9110  | c2552608-6ca4-4334-8ef7-3dbf6cb0f1c5                             |
| latest   | 192.168.178.80:60143 | com.owncloud.api-1ec09443-c0cf-422f-a9f6-2c1703c84c09            |
| 79f45cb7 | 192.168.178.80:9190  | 3cb05f0f-2b09-435b-8459-7549e7873f87                             |
| 0.0.0    | 192.168.178.80:9100  | f40ff5f1-d1e2-4b70-a152-d501e9b11171                             |
| latest   | 192.168.178.80:60145 | com.owncloud.web-ef410330-ba68-4122-8e11-6376ea52414e            |
+----------+----------------------+------------------------------------------------------------------+

Which still contains some latest and one 0.0.0.

@C0rby
Copy link
Contributor Author

C0rby commented Nov 20, 2020

Yeah, the latest and 0.0.0 are not really "our services".
The rows with latest are the namespaces.
And the 0.0.0 I don't know.

@C0rby
Copy link
Contributor Author

C0rby commented Nov 20, 2020

We could filter them out if necessary.

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good like it is! 🚀

@sonarcloud
Copy link

sonarcloud bot commented Nov 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@C0rby C0rby merged commit 2069802 into master Nov 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the ocis-version-command branch November 20, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants