Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-only] added the details to the 'Restore Trash-Bins Items' doc section' #9228

Merged
merged 10 commits into from
May 22, 2024
Merged

[docs-only] added the details to the 'Restore Trash-Bins Items' doc section' #9228

merged 10 commits into from
May 22, 2024

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented May 21, 2024

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

phil-davis
phil-davis reviewed May 21, 2024
View reviewed changes
services/storage-users/README.md Outdated Show resolved Hide resolved
services/storage-users/README.md Outdated Show resolved Hide resolved
services/storage-users/README.md Outdated Show resolved Hide resolved
2403905 and others added 8 commits May 22, 2024 09:18
mmattel
mmattel approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mmattel mmattel mentioned this pull request May 22, 2024
Closed
@mmattel
Copy link
Contributor

mmattel commented May 22, 2024

Error response from daemon: No such image: owncloudci/golang:1.22
Needs rebase after fixing.

@2403905 2403905 requested a review from d7oc May 22, 2024 08:41
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

d7oc
d7oc approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@d7oc d7oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2403905 2403905 merged commit 23aa7b6 into owncloud:master May 22, 2024
2 checks passed
ownclouders pushed a commit that referenced this pull request May 22, 2024
@2403905
Merge pull request #9228 from 2403905/storage-users-doc
7d96baa 
[docs-only]  added the details to the 'Restore Trash-Bins Items' doc section'
@mmattel mmattel mentioned this pull request Jun 3, 2024
Merged
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmattel mmattel mmattel approved these changes

@phil-davis phil-davis phil-davis approved these changes

@d7oc d7oc d7oc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@2403905 @mmattel @phil-davis @d7oc