Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K6 Testing #941

Merged
merged 8 commits into from
Nov 24, 2020
Merged

K6 Testing #941

merged 8 commits into from
Nov 24, 2020

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Nov 24, 2020

add k6 as load tester

@fschade fschade requested a review from refs November 24, 2020 13:26
Copy link
Member

@refs refs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 yesssss thanks for the TS, long time no work with it <3.

"plugins": [
"lodash",
"@babel/proposal-class-properties",
"@babel/proposal-object-rest-spread"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this plugin even if we're not explicitly using the spread operator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not right now, but soon we will... for example

http.puthttps://foo.bar", {headers: {...defaultHeaders(), foo: 'bar'}})

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly, spread is a handy one 👍

import multiInput from 'rollup-plugin-multi-input';
import path from 'path';

const extensions = ['.js', '.jsx', '.ts', '.tsx']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsx and tsx leftover from some react? I think we won't have view files here, orrrr?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea its a left over, it can be removed

@IljaN IljaN self-requested a review November 24, 2020 13:44
Copy link
Member

@IljaN IljaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also integrate in to Makefile? (if possible)
👍

@fschade
Copy link
Contributor Author

fschade commented Nov 24, 2020

Maybe also integrate in to Makefile? (if possible)
👍

yea, sure... but first i need to get this landed as a base. later it gets an real integration

@refs
Copy link
Member

refs commented Nov 24, 2020

@fschade you might want to add a changelog

@fschade fschade closed this Nov 24, 2020
@fschade fschade deleted the k6 branch November 24, 2020 14:13
@fschade fschade restored the k6 branch November 24, 2020 14:15
@fschade fschade reopened this Nov 24, 2020
@owncloud owncloud deleted a comment from update-docs bot Nov 24, 2020
@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@@ -0,0 +1,22 @@
{
Copy link
Contributor

@phil-davis phil-davis Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has a space at the beginning of the file name?
Was that intended?

@phil-davis
Copy link
Contributor

What do we do about Codacy results on this sort of stuff? Merge anyway? Add it to an exclusion list? Adjust the formatting etc to make Codacy happy?

@fschade fschade merged commit 4452d16 into master Nov 24, 2020
ownclouders pushed a commit that referenced this pull request Nov 24, 2020
Author: Florian Schade <[email protected]>
Date:   Tue Nov 24 18:39:27 2020 +0100

    K6 Testing (#941)

    * first k6 tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants