Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [docs-only] feat: create ocis_full compose deployment #9442

Merged
merged 11 commits into from
Jun 28, 2024

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Jun 21, 2024

Description

  • Port ocis_wopi deployment to master
  • Rename it to ocis_full
  • Use the new collaboration service
  • Use the CSP mechanisms properly
  • Add clamav option
  • Clean up
  • Make it usable for the continuous Deployments
  • Remove ocis_traefik
  • Remove ocis_clamav
  • Decide what to do with S3, include as option here? @tbsbdr @dragotin ?
  • Cleanup docs
  • Add docs

Related Issue

  • Fixes <issue_link>

Documentation Changes

1719492409025

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar micbar force-pushed the full-deployment branch 7 times, most recently from 9fd6f89 to 63aced3 Compare June 24, 2024 14:09
@micbar micbar requested a review from fschade June 24, 2024 15:29
deployments/examples/ocis_full/.env Show resolved Hide resolved
deployments/examples/ocis_full/.env Show resolved Hide resolved
deployments/examples/ocis_full/.env Show resolved Hide resolved
deployments/examples/ocis_full/.env Show resolved Hide resolved
deployments/examples/ocis_full/.env Outdated Show resolved Hide resolved
docs/ocis/deployment/ocis_full.md Show resolved Hide resolved
docs/ocis/deployment/ocis_full.md Show resolved Hide resolved
docs/ocis/deployment/ocis_full.md Outdated Show resolved Hide resolved
docs/ocis/deployment/ocis_full.md Outdated Show resolved Hide resolved
docs/ocis/deployment/ocis_full.md Show resolved Hide resolved
@micbar micbar force-pushed the full-deployment branch 2 times, most recently from be03cc5 to 1db11e8 Compare June 27, 2024 12:42
@micbar micbar marked this pull request as ready for review June 27, 2024 12:49
docs/ocis/deployment/ocis_full.md Outdated Show resolved Hide resolved
docs/ocis/deployment/ocis_full.md Outdated Show resolved Hide resolved
@ScharfViktor
Copy link
Contributor

  1. I see that that collabora is enabled by default but cannot open file in collabora

Steps

Actual:
Screenshot 2024-06-28 at 11 23 38

  1. I guess that wopiserver.owncloud.test is not needed in hosts more
Screenshot 2024-06-28 at 11 29 09

@micbar
Copy link
Contributor Author

micbar commented Jun 28, 2024

I guess that wopiserver.owncloud.test is not needed in hosts more

That is still needed.

@micbar
Copy link
Contributor Author

micbar commented Jun 28, 2024

I see that that collabora is enabled by default but cannot open file in collabora

Can you test again? It needs a waiting time until the colabora has fired up, the collaboration service waits until collabora is fully up and running before it registers the app. Then you need a reload of the page.

@micbar micbar requested a review from ScharfViktor June 28, 2024 09:42
@micbar
Copy link
Contributor Author

micbar commented Jun 28, 2024

And: small but important: You need OCIS_DOCKER_IMAGE=owncloud/ocis-rolling in the .env file.

@micbar
Copy link
Contributor Author

micbar commented Jun 28, 2024

maybe we should make the rolling image the default one.

@ScharfViktor

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Jun 28, 2024

Can you test again? It needs a waiting time until the colabora has fired up, the collaboration service waits until collabora is fully up and running before it registers the app. Then you need a reload of the page.

unfortunately, it doesn't work. We can see together(I'm in zoom)

ocis_full-collaboration in the restarting status with message:
The WOPI secret has not been set properly in your config for collaboration.

@micbar
Copy link
Contributor Author

micbar commented Jun 28, 2024

Ah, now I know. My changes to the init.go are not affecting you because the docker image still contains the wrong init code.

@micbar
Copy link
Contributor Author

micbar commented Jun 28, 2024

We need to merge and then it works with rolling master

@ScharfViktor
Copy link
Contributor

We need to merge and then it works with rolling master

let try. I can test it after merging.

Copy link

sonarcloud bot commented Jun 28, 2024

@ScharfViktor ScharfViktor merged commit eb5a9ce into master Jun 28, 2024
4 checks passed
@ScharfViktor ScharfViktor deleted the full-deployment branch June 28, 2024 10:51
ownclouders pushed a commit that referenced this pull request Jun 28, 2024
✨ [docs-only] feat: create ocis_full compose deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants