Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-only] update env_vars.yaml post Activitylog API merge #9466

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Jun 25, 2024

References: #9361 (Activity API)

After #9361 was merged, we need to update the helper yaml file to show correct values in docs.

@mmattel
Copy link
Contributor Author

mmattel commented Jun 25, 2024

CI hangs, no PR issue

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions.

when 'memory' or 'ocmem' stores are configured. Note that the behaviour how nodes
are used is dependent on the library of the configured store. See the Environment
Variable Types description for more details.
introductionVersion: pre5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are "interesting", changing from "5.0" to "pre5.0"

type: bool
description: 'Allow credentials for CORS.See following chapter for more details:
*Access-Control-Allow-Credentials* at https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Credentials.'
introductionVersion: pre5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I do not understand the process.
How can these new lines have introductionVersion: pre5.0 ?

Copy link
Contributor Author

@mmattel mmattel Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The process is the following:

make -C docs docs-generate parses all the envvars from all services and adds them to a kind of "database" file (this one) for further actions + another file that has no change in this PR. We need both to generate the final .adoc files. The helper takes whatever devs have done with envvars in services, therefore the helper is "neutral" about the content. To distinguish when an envvar has been added, we needed to decide which one have been introduced before 5.0. Having that, we can now clearly identify when an envvar has been introduced, respctively will get added where the release is currently not known (%%NEXT%%) or deprecated.

With an upcoming version of the helper, we will add to the adoc output WHEN the respective envvar got introduced in the admin docs. Also, we can now provide easily a list of introduced envvars for a particular release 😄

Also see the Docs Helpers description for more details.

Hope this makes sense.

@mmattel mmattel requested a review from micbar June 25, 2024 14:19
@micbar
Copy link
Contributor

micbar commented Jul 9, 2024

please rebase

@mmattel
Copy link
Contributor Author

mmattel commented Jul 9, 2024

@micbar rebase done + commit with updates containing the latest changes 😃

Copy link

sonarcloud bot commented Jul 9, 2024

@mmattel mmattel merged commit 90e789a into master Jul 9, 2024
2 checks passed
ownclouders pushed a commit that referenced this pull request Jul 9, 2024
[docs-only] update env_vars.yaml post Activitylog API merge
@mmattel mmattel deleted the fixes_docs_helper_output branch July 9, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants