Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] added test for updating admin password via cli #9593

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[tests-only][full-ci] added test for updating admin password via cli #9593

merged 1 commit into from
Jul 18, 2024

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented Jul 12, 2024 •
edited by saw-jan
Loading

Description

Added cli test for updating administrator credentials.
Previously, I directly changed the credential of administration but doing so fails the CI on ociswrapper as the admin credential is hardcoded.
Reference: https://drone.owncloud.com/owncloud/ocis/37023/43/5
due to

ocis/.drone.star

Line 2130 in ce199d5

"%s/bin/ociswrapper serve --bin %s --url %s --admin-username admin --admin-password admin" % (dirs["ocisWrapper"], ocis_bin, environment["OCIS_URL"]),

Therefore, creating a new admin user to cover this scenario.

Related Issue

How Has This Been Tested?

  • test environment:
  • locally and CI
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@S-Panta S-Panta self-assigned this Jul 12, 2024
@S-Panta S-Panta mentioned this pull request Jul 12, 2024
Open
9 tasks
@S-Panta S-Panta force-pushed the cli-test-reset-admin-credentials branch 3 times, most recently from aa0e7ec to d65b61f Compare July 15, 2024 11:51
@S-Panta S-Panta marked this pull request as ready for review July 15, 2024 11:54
@S-Panta S-Panta force-pushed the cli-test-reset-admin-credentials branch from d65b61f to b876bba Compare July 15, 2024 12:00
saw-jan
saw-jan requested changes Jul 16, 2024
View reviewed changes
tests/acceptance/features/bootstrap/CliContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/CliContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/GraphContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/cliCommands/resetUserPassword.feature Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/GraphContext.php Outdated Show resolved Hide resolved
@S-Panta S-Panta requested a review from saw-jan July 17, 2024 05:50
@S-Panta S-Panta force-pushed the cli-test-reset-admin-credentials branch from f0c832e to 1b6817d Compare July 17, 2024 11:41
@S-Panta S-Panta requested a review from saw-jan July 18, 2024 02:49
@S-Panta S-Panta force-pushed the cli-test-reset-admin-credentials branch from 1b6817d to 16cc5f2 Compare July 18, 2024 03:58
saw-jan
saw-jan approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

saw-jan
saw-jan requested changes Jul 18, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@S-Panta Could you squash the commits or reword to meaningful one?

@S-Panta S-Panta force-pushed the cli-test-reset-admin-credentials branch from 16cc5f2 to 52a0c34 Compare July 18, 2024 06:23
@S-Panta S-Panta mentioned this pull request Jul 18, 2024
Closed
3 tasks
ScharfViktor
ScharfViktor approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 775913c into master Jul 18, 2024
4 checks passed
@saw-jan saw-jan deleted the cli-test-reset-admin-credentials branch July 18, 2024 07:11
ownclouders pushed a commit that referenced this pull request Jul 18, 2024
@saw-jan
Merge pull request #9593 from owncloud/cli-test-reset-admin-credentials
3797d8b 
[tests-only][full-ci] added test for updating admin password via cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@prashant-gurung899 prashant-gurung899 Awaiting requested review from prashant-gurung899

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@nabim777 nabim777 Awaiting requested review from nabim777

Assignees

@S-Panta S-Panta

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QA] CLI test to reset admin password
3 participants
@S-Panta @saw-jan @ScharfViktor