Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Fix a11y issues from release 7.1.3 #1530

Draft
wants to merge 34 commits into
base: master
Choose a base branch
from
Draft

Fix a11y issues from release 7.1.3 #1530

wants to merge 34 commits into from

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jul 23, 2021

@update-docs
Copy link

update-docs bot commented Jul 23, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

pascalwengerter and others added 6 commits January 25, 2022 15:22
A11y Change sidebar landmark from header to figure
feat(color): higher contrast ratio on hover
style(oc-text): switched to same color group

Remove underline from breadcrumb hover adjustments
@CLAassistant
Copy link

CLAassistant commented Jan 25, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ pascalwengerter
✅ lookacat
✅ kulmann
❌ Steve Frenzel


Steve Frenzel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pascalwengerter
Copy link
Contributor

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 4 committers have signed the CLA.white_check_mark lookacatwhite_check_mark kulmannwhite_check_mark pascalwengerterx Steve Frenzel
Steve Frenzel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kulmann how do we handle this? Steve had originally signed the CLA and we have commits by him on master also, not sure why it fails now

@kulmann
Copy link
Member Author

kulmann commented Jan 25, 2022

@kulmann how do we handle this? Steve had originally signed the CLA and we have commits by him on master also, not sure why it fails now

CLA was originally signed at the time when the commits were made and we won't be able to cherry-pick any of this to master anyway. So IMO it just looks ugly on this PR now, which is only cosmetic.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants