Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox appends underscores before and after the file name upon download #11031

Closed
dutty5 opened this issue Jun 12, 2024 · 3 comments
Closed
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@dutty5
Copy link

dutty5 commented Jun 12, 2024

Describe the bug

Firefox appends underscores before and after the file name of the downloaded file

Steps to reproduce

  1. Start Firefox
  2. Navigate to oCIS personal folder
  3. Select any single file by clicking the checkbox and click download. Alternatively, use context menu.
  4. Downloaded file will have appended underscores in the beginning and in the end of the filename, for example 'text.xlsx' wil be downloaded and saved as '_test.xlsx_'.

Expected behavior

There should be no appending underscores in the filename upon download.

Actual behavior

Firefox appends underscores before and after the file name of the downloaded file

Setup

  • oCIS bare metal setup, version 5.0.5, Web version 8.0.2, on RHEL 8.10
  • Freshly installed Firefox 115.12.0esr and 127.0 checked on Mac OS Sonoma 14.5 and Big Sur 11 - same behavior
  • also checked freshly installed Firefox 115.12.0esr on Windows 8.1 - same behavior

Additional context

Similar looking problem mentioned here https://stackoverflow.com/questions/22477273/firefox-and-chrome-appending-underscore-before-and-after-file-name-while-interne

However oCIS has this problem only in Firefox. Safari, Chrome and Edge seem to be fine.

[update]
I checked with different file types (file extensions) and I observe this behavior with *.txt, *.xlsx, *.docx, *.tar.gz, *.drawio (underscores added both in the beginning and in the end). For *.pdf and *.mp4 only leading underscore is appended, and the file extension in the end of a filename remains (properly) unchanged. Characters in the filename seem to be not a factor.

[update2]
Looks like something changed in latest Firefox versions (probably JS engine related). I do not see this problem in Firefox 115.10.0esr.

@dutty5 dutty5 added the Type:Bug Something isn't working label Jun 12, 2024
@dutty5
Copy link
Author

dutty5 commented Jun 12, 2024

Might be related (?): https://www.tenable.com/cve/CVE-2024-5692

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Jun 24, 2024

Using FF 123.0.1 (64-bit): The described error doesn't appear. After updating to 127.0.1 (64-bit) the problem does indeed exist.

image

@JammingBen
Copy link
Collaborator

Has been fixed via cs3org/reva#4748 and will be part of the upcoming ocis rolling release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants