fix: quotes in content-disposition header #4748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
force-pushed
the
fix/quotes-content-disposition-header
branch
from
f958054
to
6f42cd2
Compare
Replaces the quotes by actually encoding the filename in the dav `Content-Disposition` header. The value of the `filename*` parameter must not be surrounded by any quotes, but rather be encoded in the first place. See RFC-6266 for more details. The quotes caused an issue where certain browsers would decode the quotes and falsely prepend them to the filename.
JammingBen
force-pushed
the
fix/quotes-content-disposition-header
branch
from
6f42cd2
to
d9a5e03
Compare
JammingBen
changed the title
|
@saw-jan Do you know if the CI is currently flaky? I can't get it green, there always some test(s) failing. They are located in |
tests with posix-fs were flaky previously. owncloud/ocis#9340 |
JammingBen
force-pushed
the
fix/quotes-content-disposition-header
branch
from
c2a533e
to
d9a5e03
Compare
kobergj
reviewed
Jul 4, 2024
kobergj
approved these changes
Jul 4, 2024
This was referenced Jul 8, 2024
This was referenced Jul 10, 2024
JammingBen
added a commit
to JammingBen/reva
that referenced
this pull request
Jul 10, 2024
Fixes the encoding of blanks in the dav `Content-Disposition` header. This is a regression caused by cs3org#4748.
JammingBen
added a commit
to JammingBen/reva
that referenced
this pull request
Jul 10, 2024
Fixes the encoding of blanks in the dav `Content-Disposition` header. This is a regression caused by cs3org#4748.
JammingBen
added a commit
to JammingBen/reva
that referenced
this pull request
Jul 11, 2024
Fixes the encoding of blanks in the dav `Content-Disposition` header. This is a regression caused by cs3org#4748.
JammingBen
added a commit
to JammingBen/reva
that referenced
this pull request
Jul 11, 2024
Fixes the encoding of blanks in the dav `Content-Disposition` header. This is a regression caused by cs3org#4748.
JammingBen
added a commit
to JammingBen/reva
that referenced
this pull request
Jul 12, 2024
Fixes the encoding of blanks in the dav `Content-Disposition` header. This is a regression caused by cs3org#4748.
JammingBen
added a commit
to JammingBen/reva
that referenced
this pull request
Jul 15, 2024
Fixes the encoding of blanks in the dav `Content-Disposition` header. This is a regression caused by cs3org#4748.
JammingBen
added a commit
to JammingBen/reva
that referenced
this pull request
Jul 15, 2024
Fixes the encoding of blanks in the dav `Content-Disposition` header. This is a regression caused by cs3org#4748.
JammingBen
added a commit
that referenced
this pull request
Jul 29, 2024
…er-stable [backport #4748] fix: quotes in content-disposition header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the quotes by actually encoding the filename in the dav
Content-Dispositionheader. The value of thefilename*parameter must not be surrounded by any quotes, but rather be encoded in the first place. See RFC-6266 for more details.The quotes caused an issue where certain browsers would decode the quotes and falsely prepend them to the filename.
refs owncloud/web#11031