[backport #4748] fix: quotes in content-disposition header

[JammingBen]

Backports #4748 to stable-2.19.

Needs to wait for #4762.

[JammingBen]

@saw-jan Do you know how expected failures work for stable branches? I can't get CI to recognize the correct lines, I guess because the line numbers changed on master. I tried with coreApiWebdavOperations/downloadFile.feature:214, which is the correct line number on current master. And I tried coreApiWebdavOperations/downloadFile.feature:266, which is the correct number on stable-5.0. However, I can't get it to work with any of these.

[saw-jan]

@saw-jan Do you know how expected failures work for stable branches? I can't get CI to recognize the correct lines, I guess because the line numbers changed on master. I tried with coreApiWebdavOperations/downloadFile.feature:214, which is the correct line number on current master. And I tried coreApiWebdavOperations/downloadFile.feature:266, which is the correct number on stable-5.0. However, I can't get it to work with any of these.

As per the .drone.env, with stable-2.19 reva branch, the expected failure will try to match the line numbers from ocis master branch and commit 2e7f0252f2a1b2c8200bf0931274b9e9e83f3c0a

[saw-jan]

Line number should be according to this file: https://github.com/owncloud/ocis/blob/2e7f0252f2a1b2c8200bf0931274b9e9e83f3c0a/tests/acceptance/features/coreApiWebdavOperations/downloadFile.feature

[JammingBen]

Line number should be according to this file: https://github.com/owncloud/ocis/blob/2e7f0252f2a1b2c8200bf0931274b9e9e83f3c0a/tests/acceptance/features/coreApiWebdavOperations/downloadFile.feature

Based on this, I added downloadFile.feature:266 and downloadFile.feature:299 to the list of expected failures. But still CI is failing: https://drone.owncloud.com/cs3org/reva/4969/15/6

Or do I need to add all the failing lines, as in 284-296 and 317-321?

[saw-jan]

Based on this, I added downloadFile.feature:266 and downloadFile.feature:299 to the list of expected failures. But still CI is failing: https://drone.owncloud.com/cs3org/reva/4969/15/6

Or do I need to add all the failing lines, as in 284-296 and 317-321?

yeah, to make the ci green, all failing tests must be added to the list and remove the passing lines

[JammingBen]

yeah, to make the ci green, all failing tests must be added to the list and remove the passing lines

Ahh okay, I though the test scenario line is sufficient. Got it, thanks!

[JammingBen]

@micbar This backport PR is generally ready, however, one build pipeline is failing: https://github.com/cs3org/reva/actions/runs/9939700539/job/27454800157?pr=4761. Doesn't look related to me, any idea what might be happening?

[dragonchaser]

@JammingBen you need to pick the Dockerfile.revad-cephfs changes from this commit: 650b056

uncommenting the sed in line 23 should probably be sufficient.

[JammingBen]

@JammingBen you need to pick the Dockerfile.revad-cephfs changes from this commit: 650b056

uncommenting the sed in line 23 should probably be sufficient.

Applying all the changes to the file worked, thanks!