Skipping searchbar preview on reload #10232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
JammingBen
reviewed
Dec 22, 2023
There was a problem hiding this comment.
LGTM and works as expected 👍 Could you please add a changelog item for the bugfix?
Edit: e2e tests are failing though. You can run them locally via:
pnpm test:e2e:cucumber tests/e2e/cucumber/features/smoke/fullTextSearch.feature:6pnpm test:e2e:cucumber tests/e2e/cucumber/features/smoke/search.feature:6
Maybe there is still a bug, or the tests need to be adjusted to the new behaviour.
kulmann
reviewed
Jan 2, 2024
| @@ -129,6 +129,7 @@ export default defineComponent({ | |||
| const optionsDropRef = ref(null) | |||
| const activePreviewIndex = ref(null) | |||
| const term = ref('') | |||
| const loadFromRoute = ref(false) | |||
There was a problem hiding this comment.
Small nitpick about the variable naming: I'd like to name this something like restoreSearchFromRoute to make it more descriptive.
JammingBen
reviewed
Jan 5, 2024
|
JammingBen
approved these changes
Jan 8, 2024
ownclouders
pushed a commit
that referenced
this pull request
Jan 8, 2024
* skipping searchbar preview on reload
ownclouders
pushed a commit
that referenced
this pull request
Jan 9, 2024
* skipping searchbar preview on reload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting "search term" from route would trigger search, which would create request on page load.
Added additional bool value to check if this change is triggered by route or user input
Related Issue
Types of changes
Checklist: