Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci]change asset path #10545

Merged
merged 2 commits into from
Mar 5, 2024
Merged

[full-ci]change asset path #10545

merged 2 commits into from
Mar 5, 2024

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Mar 5, 2024

changed path in the docker-compose because WEB_ASSET_PATH is deprecated
it was reason why I could not build fresh web

see here: owncloud/ocis#8523 (comment)

Copy link

update-docs bot commented Mar 5, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor changed the title change asset path [full-ci]change asset path Mar 5, 2024
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@AlexAndBear AlexAndBear merged commit 540b1cb into stable-8.0 Mar 5, 2024
3 checks passed
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait... no. This is correct for master, but not for stable-8.0.

@delete-merged-branch delete-merged-branch bot deleted the changeAssetPath branch March 5, 2024 20:14
@AlexAndBear
Copy link
Contributor

AlexAndBear commented Mar 5, 2024

Damned

but we use ocis master as image, does this make any difference ?

kulmann added a commit that referenced this pull request Mar 5, 2024
@kulmann
Copy link
Member

kulmann commented Mar 5, 2024

Damned

but we use ocis master as image, does this make any difference ?

Oh, you're right. We shouldn't. docker-compose stack in stable-8.0 should pull owncloud/ocis-5.0.0-rc.5

@AlexAndBear
Copy link
Contributor

Ahhh ok 😱

@ScharfViktor
Copy link
Contributor Author

Oh, you're right. We shouldn't. docker-compose stack in stable-8.0 should pull owncloud/ocis-5.0.0-rc.5

in the stable version, we also use ocis:latest
https://github.com/owncloud/web/blob/stable-8.0/docker-compose.yml#L2

@kulmann
Copy link
Member

kulmann commented Mar 5, 2024

in the stable version, we also use ocis:latest https://github.com/owncloud/web/blob/stable-8.0/docker-compose.yml#L2

We shouldn't :-)

@ScharfViktor could you recreate this pull request and point it at the master branch?

ScharfViktor added a commit that referenced this pull request Mar 5, 2024
* change asset path

* Trigger ci
AlexAndBear pushed a commit that referenced this pull request Mar 5, 2024
ownclouders pushed a commit that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants