Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drop down menu to app top bar #11057

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Add drop down menu to app top bar #11057

merged 2 commits into from
Jun 18, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jun 18, 2024 •
edited
Loading

Description

image

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Jun 18, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title Init Add drop down menu to app top bar Jun 18, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
22.2% Duplication on New Code

See analysis details on SonarCloud

JammingBen
JammingBen approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works nicely 👍

@pascalwengerter
Copy link
Contributor

pascalwengerter commented Jun 18, 2024 •
edited
Loading

Nice seeing this come to life!

@AlexAndBear AlexAndBear merged commit bbf67bb into master Jun 18, 2024
3 checks passed
kulmann
kulmann reviewed Jun 19, 2024
View reviewed changes
changelog/unreleased/enhancement-add-action-drop-down-to-app-top-bar
@@ -0,0 +1,7 @@
Enhancement: add action drop down top app top bar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nobody noticed the typo 😓 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no :( gonna fix this asap as possible !

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beste!

kulmann
kulmann reviewed Jun 19, 2024
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too late too approve, but man I love this 🥇

@AlexAndBear
Copy link
Contributor Author

Too late too approve, but man I love this 🥇

Toodalo! 🥰

@micbar micbar mentioned this pull request Jul 8, 2024
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann left review comments

@JammingBen JammingBen JammingBen approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Web] Add context menu to app top bar
4 participants
@AlexAndBear @pascalwengerter @kulmann @JammingBen