Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show autosave indicator #11095

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Show autosave indicator #11095

merged 3 commits into from
Jun 26, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jun 25, 2024

Description

image

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

Copy link

update-docs bot commented Jun 25, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@@ -43,6 +43,9 @@
/>
</oc-drop>
</template>
<span v-if="hasAutosave" class="oc-flex oc-flex-middle">
<oc-icon name="refresh" color="white" v-oc-tooltip="autoSaveTooltipText" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we have some magic css variable for the color. if you find something good, if not then leave it with white. ;-)

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@AlexAndBear AlexAndBear enabled auto-merge (squash) June 26, 2024 05:07
Copy link

sonarcloud bot commented Jun 26, 2024

@AlexAndBear AlexAndBear merged commit 5eafa9e into master Jun 26, 2024
3 checks passed
AlexAndBear added a commit that referenced this pull request Jun 27, 2024
* Show autosave indicator

* Enhance changelog item

* Updating snapshots
@kulmann kulmann deleted the show-auto-save-indicator branch September 5, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants