Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicated elements on public link page #11137

Merged
merged 2 commits into from
Jul 5, 2024

Commits on Jul 4, 2024

  1. fix: duplicated elements on public link page

    Fixes a bug where clicking the ownCloud logo on a public link page would lead to certain UI elements being duplicated.
    
    This happens because some extensions and extension points are being registered more than once because the application layout gets unmounted on mounted again when clicking the logo. The solution is to properly unregister those extensions on unmount.
    JammingBen committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    d2e4cec View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. fix: prevent apps from re-initializing on logo click

    Prevents all apps from re-initializing when clicking the ownCloud logo on public link pages.
    
    The issue happens because clicking the logo navigates the user to the `resolvePublicLink` page, which results in the public context being reset. We can omit this reset in that case though because we can guarantee that the user will either land on a public page, or on some other route which then resets the context anyways.
    JammingBen committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    59c0d53 View commit details
    Browse the repository at this point in the history