Fix personal space name not updating after language change #8992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
requested changes
May 8, 2023
JammingBen
commented
May 8, 2023
Comment on lines
-146
to
-155
| describe('computed method "isChangePasswordEnabled"', () => { | ||
| it('should be true if capability is enabled', () => { | ||
| const { wrapper } = getWrapper({ capabilities: { spaces: { enabled: true } } }) | ||
| expect(wrapper.vm.isChangePasswordEnabled).toBeTruthy() | ||
| }) | ||
| it('should be false if capability is not enabled', () => { | ||
| const { wrapper } = getWrapper() | ||
| expect(wrapper.vm.isChangePasswordEnabled).toBeFalsy() | ||
| }) | ||
| }) |
There was a problem hiding this comment.
This was just testing the result of the useCapabilitySpacesEnabled composable, no need to test that here.
kulmann
reviewed
May 8, 2023
JammingBen
force-pushed
the
update-personal-space-name-after-language-change
branch
from
9b97eff
to
aca1b62
Compare
|
Kudos, SonarCloud Quality Gate passed! |
AlexAndBear
approved these changes
May 8, 2023
delete-merged-branch
bot
deleted the
update-personal-space-name-after-language-change
branch
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Types of changes