Remove support for VectorOfVariables constraints #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recommend to only support a constraint if the solver has a native support for it (see this tip: https://jump.dev/JuMP.jl/stable/moi/tutorials/implementing/#Define-supports_constraint).
The reason is that the bridging mechanism in MOI selects the bridges that minimize the number bridges needed to transform the user constraints into constraints supported by the solver.
If the solver hardcodes some bridges then these transformations are not taken into account by the bridge shortest path heuristic.
For instance, there are two bridges in SumOfSquares, a Kernel bridge which is best for solvers supporting PSD variables and equality constraints and an Image bridge which is best if the solver supports VectorAffineFunction-in-PSD.
The bridge heuristic should use the Image bridge with Clarabel and the Kernel bridge if Clarabel is used with Dualization.jl.
See https://youtu.be/CGPHaHxCG2w?t=590