Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React18 compatibility #156

Closed
wants to merge 1 commit into from
Closed

React18 compatibility #156

wants to merge 1 commit into from

Conversation

marcelovicentegc
Copy link

@marcelovicentegc marcelovicentegc commented Oct 27, 2022

Hey, all! I'm opening this PR because I came across the errors reported on #153 and the changes on this PR made it work on my React18 + NextJS project. I have no idea why it worked, but I have patched these changes in my application and nothing broke.

All I know is that I am using it correctly (per docs), along with React 18 + NextJS:

<Truncate lines={width < breakpoints.md ? 4 : 2}>
    A text as string, as you can see, no text formatting, no html, markdown or any formatting language here.
</Truncate>

In case anyone is interested in moving this piece of code forward in this library, go ahead! cc @pablosichert

@allanwsilva
Copy link

@marcelovicentegc Should the reference to node in package.json be bumped as well?

@marcelovicentegc marcelovicentegc closed this by deleting the head repository Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants