Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop distributing radv #103

Closed
zmike opened this issue May 18, 2022 · 6 comments
Closed

stop distributing radv #103

zmike opened this issue May 18, 2022 · 6 comments

Comments

@zmike
Copy link

zmike commented May 18, 2022

RADV does not work on Windows. This is not a bug or a missing feature, it just isn't going to work. Distributing it in this package implies that it will, and this wastes the time of anyone who tries to use it.

pal1000 added a commit that referenced this issue May 19, 2022
@pal1000
Copy link
Owner

pal1000 commented May 22, 2022

@zmike you should be aware that if LLVM is built with AMDGPU target, Microsoft CLC fails to build if RADV isn't built as well.

Anyway I took your suggestion for 22.1.0.

@pal1000 pal1000 closed this as completed May 22, 2022
@zmike
Copy link
Author

zmike commented May 22, 2022

Great, thanks!

@zmike you should be aware that if LLVM is built with AMDGPU target, Microsoft CLC fails to build if RADV isn't built as well.

I don't think this is a RADV issue though? At a minimum, if you have to build RADV to work around this for now, you could just not distribute RADV after.

@pal1000
Copy link
Owner

pal1000 commented May 22, 2022

I don't think this is a RADV issue though?

It's not. It's a Microsoft CLC / clover issue. It was worked around for clover only when using LLVM config tool. Reading meson.build I can tell the work around doesn't apply for
Microsoft CLC though.

@zmike
Copy link
Author

zmike commented May 22, 2022

Maybe file another bug? Or update that one. Dunno, but it sounds like it should be fixed.

@oscarbg
Copy link

oscarbg commented Aug 26, 2022

don't asking for enabling RADV again but note I found some usage for RADV for Windows in :
tgjones/shader-playground#102
"It might be nice to experiment with, and it already compiles as a Vulkan ICD on Windows. It just needs RADV_FORCE_FAMILY to be set, and NIR/ACO output is available as text via VK_KHR_pipeline_executable_properties."

@Weather-OS
Copy link

Weather-OS commented Jul 10, 2024

Reopen this issue.
https://www.phoronix.com/news/Experimental-RADV-Windows

Time to pop some confetti!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants