Nested group matrix should not be reset.

[sasensi]

Description/Steps to reproduce

Originally reported here.
When two groups are nested and the parent has matrix applied and the child has matrix not applied.
If we first do a transformation on the child, its matrix is updated as expected.
But if we then do a transformation on the parent, the child matrix is unexpectedly reset.

Link to reproduction test-case

Here is a sketch reproducing the issue.

// Create nested groups.
var childGroup = new Group({ applyMatrix: false });
var parentGroup = new Group([childGroup]);

// Transform child.
childGroup.scale(10);

// Matrix is updates as expected.
// Outputs: 10
console.log(childGroup.scaling.x);

// Transform parent.
parentGroup.scale(1.1);

// Matrix was unexpectedly reset.
// Outputs: 1 (instead of 10)
console.log(childGroup.scaling.x);

Expected result

Child matrix should not be reset.

[lehni]

@sasensi merging this has actually broke the examples/Paperjs.org/PathIntersections.html example, see attached screenshot.

Could you look into what's going wrong here?

[lehni]

This is blocking the release of a new version… We should also implement a unit test for whatever was broken here.

[Filprots]

Hello. I've made a sketch representing the broken example.
I've uncovered this bug, so i'll be happy if it'll help you to solve it.

SKETCH

[sasensi]

@lehni, sorry for the delay, I am overflowed by work currently.
Was your last commit (that closed this thread) able to fix the issue ?

[lehni]

@sasensi no worries, I know too well how that goes ;) Yes, my change fixes the new bug as well as the original issue here. Your test is still there and passes. Should be all good!

[lehni]

@sasensi …and I added a test for the new issue here:

c82e5d4#diff-d0910dfd0a27fc801d12c43b3c3e040fR202

[sasensi]

@lehni, ok, great, thank you !