max_concurrent_outbound_dials does not restrict max concurrent outbound dials

[mattsse]

Describe the feature

The max_concurrent_outbound_dials

reth/crates/net/network/src/peers/manager.rs

Lines 832 to 834 in a7e183d

	/// Maximum allowed concurrent outbound dials.
	#[cfg_attr(feature = "serde", serde(default))]
	max_concurrent_outbound_dials: usize,

only restricts how many new outbound dials we create at once but this does not respect how many are already in progress atm.

reth/crates/net/network/src/peers/manager.rs

Line 702 in a7e183d

while self.connection_info.has_out_capacity() {

This should instead restrict how many outbound dials we allow at once and should slow down new connections if exceeded.

TODO

This can be solved by a new connection state and counter that is PendingOut

reth/crates/net/network/src/peers/manager.rs

Lines 822 to 824 in a7e183d

	/// Counter for currently occupied slots for active outbound connections.
	#[cfg_attr(feature = "serde", serde(skip))]
	num_outbound: usize,

reth/crates/net/network/src/peers/manager.rs

Lines 1021 to 1022 in a7e183d

	/// Connected via outgoing connection.
	Out,

when we initiate an outgoing connection the peer's state is set to PendingOut and counter increased.

once the session is established or failed we need to update the state and counter for all possible cases:

reth/crates/net/network/src/peers/manager.rs

Line 850 in a7e183d

fn decr_state(&mut self, state: PeerConnectionState) {

reth/crates/net/network/src/peers/manager.rs

Line 386 in a7e183d

pub(crate) fn on_pending_session_gracefully_closed(&mut self, peer_id: &PeerId) {

and need a new function on_active_session_established that then shifts the peer's state from PendingOut to Out

Additional context

No response

[abhijeetbhagat]

@mattsse i can take this

[mattsse]

nice, lmk if anything's unclear

[abhijeetbhagat]

@mattsse where should on_active_session_established be called from?

[mattsse]

from top level, we already have it for incoming, we also need it for outgoing:

reth/crates/net/network/src/manager.rs

Lines 733 to 738 in be6d505

	if direction.is_incoming() {
	this.swarm
	.state_mut()
	.peers_mut()
	.on_incoming_session_established(peer_id, remote_addr);
	}