restrict max concurrent outbound dials #6860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijeetbhagat
requested review from
emhane,
mattsse and
Rjected
as code owners
mattsse
requested changes
Feb 28, 2024
There was a problem hiding this comment.
this looks pretty good!
I believe this is already complete.
I'd like to see another test case that adds a few peers
- starts all allowed pendingOut (until max_concurrent is satisfied)
- calls on_active_outgoing_established
ensures peers are now::Outand counters are as expected
mattsse
added
C-enhancement
|
@mattsse can you please check if the test case looks good? |
|
@mattsse please check. |
|
@mattsse please check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6778