Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable unused_crate_dependencies rustc lint #6890

Closed
DaniPopes opened this issue Feb 29, 2024 · 1 comment · Fixed by #6899
Closed

Enable unused_crate_dependencies rustc lint #6890

DaniPopes opened this issue Feb 29, 2024 · 1 comment · Fixed by #6899
Assignees
@justcode740
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@DaniPopes
Copy link
Member

Describe the feature

Add #![cfg_attr(not(test)), warn(unused_crate_dependencies)] in all crates' lib.rs and remove unused dependencies.

Don't add if false positives are encountered.

cc @jsvisa

Additional context
@DaniPopes DaniPopes added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Feb 29, 2024
@justcode740
Copy link
Contributor

will take a look

@DaniPopes DaniPopes mentioned this issue Feb 29, 2024
Merged
@justcode740 justcode740 mentioned this issue Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justcode740 justcode740

Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

0x/rm unused dep justcode740/reth
2 participants
@DaniPopes @justcode740