Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove cargo-udeps-related workflow and metadata #6889

Merged
merged 1 commit into from
Feb 29, 2024
Merged

chore: remove cargo-udeps-related workflow and metadata #6889

merged 1 commit into from
Feb 29, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Feb 29, 2024 •
edited
Loading

Doesn't really work and there is the unused_crate_dependencies rustc lint which is what we really want. #6890

mattsse
mattsse approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, honestly this was more annoying than useful

we should use the native lint

@mattsse mattsse added the A-meta Changes in the contributor workflow and planning label Feb 29, 2024
@DaniPopes DaniPopes added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit b00e3f9 Feb 29, 2024
29 checks passed
@DaniPopes DaniPopes deleted the dani/rm-udeps branch February 29, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-meta Changes in the contributor workflow and planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DaniPopes @mattsse