Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eth and optimism cli chainspec parser #9266

Closed
Tracked by #7576
mattsse opened this issue Jul 3, 2024 · 1 comment · Fixed by #9366
Closed
Tracked by #7576

add eth and optimism cli chainspec parser #9266

mattsse opened this issue Jul 3, 2024 · 1 comment · Fixed by #9366
Assignees
Labels
A-db Related to the database D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 3, 2024

Add implementations of

pub trait ChainSpecParser: TypedValueParser<Value = Arc<ChainSpec>> + Default {

for ethereum and optimism

basically:

pub fn chain_value_parser(s: &str) -> eyre::Result<Arc<ChainSpec>, eyre::Error> {

but specifically for op and eth

first impl should just reuse this function as is

FYI @loocapro

@mattsse mattsse changed the title add eth and optimism cli parser add eth and optimism cli chainspec parser Jul 3, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-db Related to the database labels Jul 3, 2024
@loocapro
Copy link
Contributor

loocapro commented Jul 3, 2024

Up for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Related to the database D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants