Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: parsers #9366

Merged
merged 5 commits into from
Jul 10, 2024
Merged

feat: parsers #9366

merged 5 commits into from
Jul 10, 2024

Conversation

loocapro
Copy link
Contributor

@loocapro loocapro commented Jul 8, 2024 •
edited
Loading

Closes: #9266

mattsse
mattsse requested changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pr already tries to integrate this in the existing cli setup, we can't do that yet.

crates/cli/cli/Cargo.toml Outdated Show resolved Hide resolved
bin/reth/src/cli/mod.rs Outdated Show resolved Hide resolved
@loocapro loocapro marked this pull request as ready for review July 8, 2024 11:53
@loocapro loocapro requested a review from mattsse July 8, 2024 11:53
mattsse
mattsse requested changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to have some duplicated code for a bit, which is fine if this allows us to make the final transition faster (soon).

crates/cli/cli/src/chainspec/mod.rs Outdated Show resolved Hide resolved
crates/cli/cli/src/chainspec/mod.rs Outdated Show resolved Hide resolved
crates/cli/cli/Cargo.toml Outdated Show resolved Hide resolved
@mattsse mattsse added the A-cli Related to the reth CLI label Jul 8, 2024
@loocapro loocapro requested a review from fgimenez as a code owner July 8, 2024 14:33
@loocapro loocapro requested a review from mattsse July 8, 2024 14:33
@mattsse mattsse enabled auto-merge July 10, 2024 12:32
@mattsse mattsse added this pull request to the merge queue Jul 10, 2024
Merged via the queue into paradigmxyz:main with commit 47c0382 Jul 10, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add eth and optimism cli chainspec parser
2 participants
@loocapro @mattsse