Feat/improve fee history performance #5182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, refactor caclulations
mattsse
requested changes
Oct 25, 2023
There was a problem hiding this comment.
thanks for this draft,
I don't want to integrate the feehistory in the ethstatecache, this should be limited to state data only.
instead we want a separate type that handles this similar to the gasoracle. that only tracks Hash to Fees, this one is accessed when the endpoint is called, if entry is missing we fetch the missing block from the state cache, compute the entry, then insert it.
eventually we can preinsert on new blocks.
…che to store fees for blocks, refactor fee_history function
mattsse
requested changes
Nov 2, 2023
… change upper_bound and lower_bound to function
…istory_performance
mattsse
requested changes
Nov 7, 2023
…istory_performance
…istory_performance
Co-authored-by: Matthias Seitz <[email protected]>
…nil/reth into feat/improve_fee_history_performance
allnil
requested review from
Rjected,
rakita,
joshieDo,
onbjerg,
rkrasiuk and
gakonst
as code owners
mattsse
requested changes
Nov 22, 2023
mattsse
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to optimize fee_history()