Prioritisation network manager + transactions manager + eth request handler #6590
Conversation
Co-authored-by: DaniPopes <[email protected]>
Co-authored-by: DaniPopes <[email protected]>
emhane
changed the title
|
dug up some helpful resources tasks can starve in tokio, just "not for too long": pre-emption in a loop can cause busy-wait: (Tokio's |
merged into main at commit 3e54d94. looking a lot better than on main. |
crates/net/network/src/manager.rs
Outdated
| let maybe_more_handle_messages = poll_nested_stream_with_yield_points!( | ||
| "net", | ||
| "Network message channel", | ||
| DEFAULT_BUDGET_TRY_DRAIN_NETWORK_HANDLE_CHANNEL, | ||
| this.from_handle_rx.poll_next_unpin(cx), | ||
| |msg| this.on_handle_message(msg), | ||
| error!("Network channel closed"); | ||
| ); |
There was a problem hiding this comment.
hmm, good point, so better be safe than sorry
yay! are you keen on getting this into beta or no? if so, it would be nice if time can be allocated to extended the prio-poll pattern to
true, good point. naming that is as coherent with the code as possible is key to readability and adoptability. |
definitely |
Closes #6589. Closes #6336.
Generalises preemption pattern from #6334 (originally from
NetworkManagerwhen pollingSwarm). Incorporates this pattern intoNetworkManageras well asTransactionsManager.Decomposed into #6656 and #6651 and this pr.