Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): add active txn before sending result #6840

Merged
merged 2 commits into from
Feb 28, 2024
Merged

fix(storage): add active txn before sending result #6840

merged 2 commits into from
Feb 28, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Feb 28, 2024

Closes #6839.

Adds a ro transaction to active map of ReadTransactions, before sending mdbx_result over channel.

shekhirin
shekhirin approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Even though this code path isn't used in Reth, because we always start read-only transactions without a TxnManagerMessage::Begin, it's correct.

@shekhirin shekhirin added C-enhancement New feature or request A-db Related to the database C-bug An unexpected or incorrect behavior and removed C-enhancement New feature or request labels Feb 28, 2024
@emhane emhane added this pull request to the merge queue Feb 28, 2024
Merged via the queue into main with commit 3179391 Feb 28, 2024
29 checks passed
@emhane emhane deleted the emhane/libmdbx-txnmanager-begin-tx branch February 28, 2024 11:32
fgimenez pushed a commit to fgimenez/reth that referenced this pull request Feb 29, 2024
@emhane @fgimenez
fix(storage): add active txn before sending result (paradigmxyz#6840)
5c0d63e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo

Assignees
No one assigned
Labels
A-db Related to the database C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race condition TxnManagerMessage::Begin
3 participants
@emhane @shekhirin @mattsse