Ensure consistency between aborted set and reused ptrs #6844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
C-bug
joshieDo
approved these changes
Feb 28, 2024
joshieDo
reviewed
Feb 28, 2024
| // reassigns same recently aborted transaction pointer. | ||
| { | ||
| let tx = env.begin_ro_txn().unwrap(); | ||
| let tx_ptr = tx.txn() as usize; |
There was a problem hiding this comment.
is it actually reassigning to the prev ptr?
There was a problem hiding this comment.
sometimes. we should proptest test these so they run more than once. try the test more than once on main and you will see it fail sometimes pass sometimes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6843.
Removes a read transaction from the aborted set if mdbx tries to reuse it (initiated by user), regardless of error code.