Revm example #6855
Merged
Revm example #6855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Feb 28, 2024
Comment on lines
+54
to
+57
| #[derive(Default, Debug, Clone)] | ||
| struct DummyInspector { | ||
| ret_val: Vec<String>, | ||
| } |
There was a problem hiding this comment.
we should add a smol doc here what this inspector does, listing opcodes at the program counter
There was a problem hiding this comment.
Sure, will do in tomorrow.
mattsse
added
C-enhancement
gakonst
reviewed
Feb 28, 2024
Comment on lines
13
to
31
| use reth::{ | ||
| cli::{ | ||
| components::{RethNodeComponents, RethRpcComponents, RethRpcServerHandles}, | ||
| config::RethRpcConfig, | ||
| ext::{RethCliExt, RethNodeCommandConfig}, | ||
| Cli, | ||
| }, | ||
| primitives::{Address, BlockId, IntoRecoveredTransaction}, | ||
| revm::{ | ||
| inspector_handle_register, interpreter::Interpreter, revm, Database, EvmContext, Inspector, | ||
| }, | ||
| rpc::{ | ||
| compat::transaction::transaction_to_call_request, | ||
| eth::{revm_utils::EvmOverrides, EthTransactions}, | ||
| }, | ||
| tasks::TaskSpawner, | ||
| transaction_pool::TransactionPool, | ||
| }; | ||
| use reth_revm::interpreter::OpCode; |
There was a problem hiding this comment.
we should make this way less verbose. Prelude or otherwise?
There was a problem hiding this comment.
these are already the reexports -.-
but can def make this nicer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6145
Add an example of how to use a custom inspector to trace new pending transactions
How to test:
and in another contracts project created by
forge, and then run the following command to deploy a transaction:forge create --mnemonic "test test test test test test test test test test test junk" src/Counter.sol:Counterhere is the running result from
node: