Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rm Signature optimism cfg #6858

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix: rm Signature optimism cfg #6858

merged 1 commit into from
Feb 28, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 28, 2024

I believe none of this is even reachable for deposit transactions.
for encoding, the signature is not included in deposit txs so we don't include them when calculating the payload len.

unclear why we had this

please check @clabby

@mattsse mattsse requested review from clabby and Rjected and removed request for gakonst February 28, 2024 21:36
@mattsse mattsse added the A-op-reth Related to Optimism and op-reth label Feb 28, 2024
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Believe this was an artifact of the very first op-reth code where we were attempting to use reth types to read from the legacy DB. This shouldn't be necessary.

Tested on our op-sepolia node, and no issues there.

@mattsse
Copy link
Collaborator Author

mattsse commented Feb 28, 2024

thanks champ

@mattsse mattsse added this pull request to the merge queue Feb 28, 2024
Merged via the queue into main with commit ecfe4b6 Feb 28, 2024
29 checks passed
@mattsse mattsse deleted the matt/rm-op-cfg branch February 28, 2024 22:09
fgimenez pushed a commit to fgimenez/reth that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants