Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: don't subscribe to consensus health events for dev node #6868

Merged
merged 1 commit into from
Feb 29, 2024
Merged

node: don't subscribe to consensus health events for dev node #6868

merged 1 commit into from
Feb 29, 2024

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Feb 29, 2024

I'm running a node with --dev locally, but happened to see the annoying no updates messages, eg:

2024-02-29T03:03:54.059470Z  WARN Beacon client online, but no consensus updates received for a while. Please fix your beacon client to follow the chain! period=530.582623334s
2024-02-29T03:03:57.058854Z  INFO Status connected_peers=0 freelist=17 latest_block=2
2024-02-29T03:04:22.058239Z  INFO Status connected_peers=0 freelist=17 latest_block=2
2024-02-29T03:04:47.057463Z  INFO Status connected_peers=0 freelist=17 latest_block=2
2024-02-29T03:08:32.046472Z  INFO Status connected_peers=0 freelist=17 latest_block=2
...
2024-02-29T03:08:54.047061Z  WARN Beacon client online, but no consensus updates received for a while. Please fix your beacon client to follow ...

As the beacon client in --dev mode is a simulator, so we don't need to subscribe to the health events.

mattsse
mattsse approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, yeah that makes sense!

ty

@mattsse mattsse added this pull request to the merge queue Feb 29, 2024
@mattsse mattsse added the C-debt A section of code is hard to understand or change label Feb 29, 2024
Merged via the queue into paradigmxyz:main with commit 2eb2a0c Feb 29, 2024
29 checks passed
@jsvisa jsvisa deleted the dev-node-no-cl-health branch February 29, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-debt A section of code is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsvisa @mattsse