Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-core, storage): static files segment metrics #6908

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Mar 1, 2024

Holesky

reth (alexey/static-files-segment-metrics) curl -s localhost:9001 | rg '^reth_static_files_segment' | sort
reth_static_files_segment_entries{segment="headers"} 1049527
reth_static_files_segment_entries{segment="receipts"} 32422175
reth_static_files_segment_entries{segment="transactions"} 32422175
reth_static_files_segment_files{segment="headers"} 3
reth_static_files_segment_files{segment="receipts"} 3
reth_static_files_segment_files{segment="transactions"} 3
reth_static_files_segment_size{segment="headers"} 456090364
reth_static_files_segment_size{segment="receipts"} 2274578626
reth_static_files_segment_size{segment="transactions"} 20599193088

To my surprise, no overhead 🤔

reth (alexey/static-files-segment-metrics) hyperfine 'curl -s localhost:9001' -n 'alexey/static-files-segment-metrics'
Benchmark 1: alexey/static-files-segment-metrics
  Time (mean ± σ):      27.4 ms ±   1.8 ms    [User: 1.8 ms, System: 2.7 ms]
  Range (min … max):    25.6 ms …  37.7 ms    73 runsreth (main) hyperfine 'curl -s localhost:9001' -n 'main'
Benchmark 1: main
  Time (mean ± σ):      28.6 ms ±   1.1 ms    [User: 1.9 ms, System: 2.9 ms]
  Range (min … max):    27.5 ms …  36.7 ms    92 runs

image

@shekhirin shekhirin added C-enhancement New feature or request A-observability Related to tracing, metrics, logs and other observability tools A-static-files Related to static files labels Mar 1, 2024
@shekhirin shekhirin requested a review from mattsse March 1, 2024 12:11
@shekhirin shekhirin marked this pull request as ready for review March 1, 2024 12:11
@shekhirin shekhirin force-pushed the alexey/static-files-segment-metrics branch from 23d8b9e to 269869e Compare March 1, 2024 14:13
@shekhirin shekhirin added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit ea44c1d Mar 1, 2024
29 checks passed
@shekhirin shekhirin deleted the alexey/static-files-segment-metrics branch March 1, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-static-files Related to static files C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants