test(ef-tests, storage): do not sync_all static files in state tests

[shekhirin]

There's no need to ensure that all in-memory buffers are flushed to disk for tests, because we don't reuse this data anymore after we finish.

Even if the modifications have not made it to disk yet, the OS uses its buffer cache to reflect file modifications and guarantees atomicity level for reads and writes, to ALL processes. So not only your process, but any other process, would be able to see the changes.

source: https://stackoverflow.com/a/8547094

---

The removal of this sync_all

reth/crates/storage/nippy-jar/src/writer.rs

Lines 114 to 117 in 8ea032a

	// First byte of the offset file is the size of one offset in bytes
	offsets_file.write_all(&[OFFSET_SIZE_BYTES as u8])?;
	offsets_file.sync_all()?;
	offsets_file.seek(SeekFrom::End(0))?;

is fine because we do it when actually writing the offsets.

[shekhirin]

@joshieDo can you please check if the removal of offsets sync_all is fine?