Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(db): race condition in Tx cached handles #6923

Merged
merged 1 commit into from
Mar 2, 2024
Merged

fix(db): race condition in Tx cached handles #6923

merged 1 commit into from
Mar 2, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Mar 1, 2024 •
edited
Loading

Switch to once_cell for get_or_try_init since there is literally no way to get this API with std OnceSync

@mattsse mattsse added C-bug An unexpected or incorrect behavior A-db Related to the database labels Mar 1, 2024
@rkrasiuk rkrasiuk linked an issue Mar 2, 2024 that may be closed by this pull request
Cached db handles access may panic (call get_dbi on more than one thread) #6922
Closed
1 task
@rkrasiuk rkrasiuk added this pull request to the merge queue Mar 2, 2024
Merged via the queue into main with commit a79db0f Mar 2, 2024
29 checks passed
@rkrasiuk rkrasiuk deleted the dani/oncelock-not-very-locked branch March 2, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin

Assignees
No one assigned
Labels
A-db Related to the database C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cached db handles access may panic (call get_dbi on more than one thread)
3 participants
@DaniPopes @mattsse @rkrasiuk